btf: make copying types infallible #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
reviewed
Apr 26, 2022
lmb
force-pushed
the
btf-copy-type
branch
2 times, most recently
from
7dfb276
to
34c0638
Compare
lmb
commented
Apr 27, 2022
We currently have an unexported copyTypes function which allows transforming a type graph before copying. This is very useful to strip qualifiers or typedefs out of a graph. The function currently returns an error, since we might not be able to remove all qualifiers, etc. in the case of deeply nested or cyclical types. Instead of returning an error, introduce an invalid sentinel Type "cycle" and use it to signal that something went wrong. This allows removing the error return which in turn allows us to extend Copy to the more powerful copyType paradigm.
ti-mo
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have an unexported copyTypes function which allows transforming
a type graph before copying. This is very useful to strip qualifiers or
typedefs out of a graph. The function currently returns an error, since we
might not be able to remove all qualifiers, etc. in the case of deeply
nested or cyclical types.
Instead of returning an error, introduce an invalid sentinel Type "cycle" and
use it to signal that something went wrong. This allows removing the error return
which in turn allows us to extend Copy to the more powerful copyType paradigm.