prog: recognize ENOTSUPP in testRun() #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
reviewed
May 3, 2022
Not all program types support PROG_TEST_RUN on all kernel versions. Previously, when testing a program type that didn't have a test runner implemented, the following error would be returned: Error when running: can't test program: can't run test: errno 524 Since this isn't overly descriptive, make it clear to the caller that the kernel supports test runs, just not for the particular program type. Also fixes haveProgTestRun on kernels between 4.12 (where PROG_TEST_RUN was introduced) and 4.16 (where sk_filter test runner was added). Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/prog-test-run-enotsupp
branch
from
d1732f5
to
0a7276f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all program types support PROG_TEST_RUN on all kernel versions. Previously, when testing a program type that didn't have a test runner implemented, the following error would be returned:
Since this isn't overly descriptive, make it clear to the caller that the kernel supports test runs, just not for the particular program type.