Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update platformPrefix list with libbpf values #982

Merged
merged 1 commit into from
Mar 23, 2023
Merged

update platformPrefix list with libbpf values #982

merged 1 commit into from
Mar 23, 2023

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Mar 22, 2023 •
edited
Loading

As a first step towards being able to compute a value for LINUX_HAS_SYSCALL_WRAPPER, this PR updates the platform prefix list with values from libbpf and go architecture list

@paulcacheux paulcacheux marked this pull request as ready for review March 22, 2023 16:22
@paulcacheux @lmb
link: update platformPrefix list with libbpf values
5a07203 
Signed-off-by: Paul Cacheux <paul.cacheux@datadoghq.com>
lmb
lmb approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did a small drive by refactoring. For HAS_SYSCALL_WRAPPER we should probably turn this into platformPrefix() string instead, so that we can tell if we don't know of a platform prefix.

@lmb lmb merged commit 6237523 into cilium:master Mar 23, 2023
@ti-mo
Copy link
Collaborator

ti-mo commented Mar 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulcacheux @ti-mo @lmb