btf: remove type alias for []Type #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
reviewed
Mar 28, 2023
lmb
force-pushed
the
btf-remove-types-slice-alias
branch
from
a1f4f07
to
8330c5d
Compare
Remove "type types []Type" since the only use case is the ByID method, which doesn't take split BTF into account. Use *Spec instead where necessary. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
btf-remove-types-slice-alias
branch
from
8330c5d
to
f9a0824
Compare
|
Removed the drive-by fix, I'll open a separate PR. |
rgo3
approved these changes
Mar 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "type types []Type" since the only use case is the ByID method, which doesn't take split BTF into account. Use *Spec instead where necessary.