Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: using certloader.ClientConfigBuilder to prepare tls.Config #151

Merged
merged 1 commit into from
Jun 21, 2021
Merged

feat: using certloader.ClientConfigBuilder to prepare tls.Config #151

merged 1 commit into from
Jun 21, 2021

Conversation

yandzee
Copy link
Collaborator

@yandzee yandzee commented Jun 16, 2021

No description provided.

@yandzee yandzee requested review from kaworu and aanm June 16, 2021 11:57
@yandzee yandzee requested a review from a team as a code owner June 16, 2021 11:57
@yandzee yandzee requested review from geakstr and rolinh and removed request for a team June 16, 2021 11:57
@gandro gandro mentioned this pull request Jun 21, 2021
Merged
@yandzee yandzee requested review from gandro and kaworu June 21, 2021 14:02
kaworu
kaworu approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yandzee thanks for addressing the feedback!

@yandzee
feat: using certloader.ClientConfigBuilder to prepare tls.Config
a003373 
Signed-off-by: Renat Tuktarov <yandzeek@gmail.com>
@yandzee yandzee merged commit d52b19c into master Jun 21, 2021
@yandzee yandzee deleted the pr/renat/config-and-tls branch June 21, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

@aanm aanm Awaiting requested review from aanm

@geakstr geakstr Awaiting requested review from geakstr

@rolinh rolinh Awaiting requested review from rolinh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yandzee @gandro @kaworu