Skip to content

Commit

Permalink
Improve grammar and terminology
Browse files Browse the repository at this point in the history
Co-authored-by: Chance Zibolski <chance.zibolski@gmail.com>
Signed-off-by: Fabian Fischer <10788152+glrf@users.noreply.github.com>
  • Loading branch information
glrf and chancez committed Sep 8, 2023
1 parent 74ea417 commit 4fb0934
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions cmd/observe/flows.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,21 +208,21 @@ func newFlowsCmdWithFilter(vp *viper.Viper, ofilter *flowFilter) *cobra.Command
* Filtering flows
Observe provide a long list of filter options. These option let us, for example,
Observe provides a long list of filter options. These options let you, for example,
filter for the used HTTP method using the '--http-method' flag. The following
command shows all flows that use the HTTP PUT method.
hubble observe --http-method put
You can also provide multiple values for a flag, in which case a flow matches the
filter if it matches any of the provided values. For our example if we add a second
filter if it matches any of the provided values. For our example if you add a second
'--http-method' flag matching GET requests, the command will show any flow that
uses either a PUT or GET method.
hubble observe --http-method put --http-method get
If we add a different flag, a flow is only returned if it matches for both of the
different flags. For example we can add a '--to-namespace' flag to our command so
If you add a different flag, a flow is only returned if it matches for both of the
different flags. For example you can add a '--to-namespace' flag to our command so
only flows using GET or PUT requests to endpoint in namespace 'foo' are returned.
hubble observe --http-method put --http-method get --to-namespace foo
Expand All @@ -232,20 +232,20 @@ func newFlowsCmdWithFilter(vp *viper.Viper, ofilter *flowFilter) *cobra.Command
hubble observe --http-method put --http-method get --to-namespace foo --to-namespace bar
* Using reversed filters
* Using negations on filters
Observe can also return all flows that don't match a certain filter by using the
'--not' flag. The following command returns all flows that don't use the HTTP PUT
method.
hubble observe --not --http-method put
Similarly to filtering for multiple values, we can also filter our multiple values.
Similarly to filtering for multiple values, you can also filter our multiple values.
The following command will return all flows that neither use a GET nor PUT method.
hubble observe --not --http-method put --not --http-method get
We can also filter using multiple reversed flags. This will then filter out all
You can also filter using multiple reversed flags. This will then filter out all
flows that match both of the flags. For example, by adding a
'--not --to-namespace foo' flag, the example command will show all flows that
don't use a GET or PUT method and end in the 'foo' namespace.
Expand All @@ -264,14 +264,14 @@ individual pods, services, TCP connections, DNS queries, HTTP requests and
more.
Observe can filter flows using multiple different flags, such as filtering for
the source namespace or the used protocol. To match a filter flag, a flow most
the source namespace or the protocol used. To match a filter flag, a flow most
match at least one of the provided values for that flag. A flow must match all
the provided filter flags to be returned.
Observe can also show all flows that do not match a provided filter, by adding
the '--not' flag in front of a filter flag. To not match a reversed filter
the '--not' flag in front of a filter flag. To match a negated filter
flag, a flow must not match any of the provided values for that flag. A returned
flow does not match at least one of the reversed filter flags.
flow does not match any of the negated filter flags.
`,
}

Expand Down

0 comments on commit 4fb0934

Please sign in to comment.