Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble observe doesn't support --until without --since #519

Closed
michi-covalent opened this issue Mar 22, 2021 · 5 comments 路 Fixed by #792
Closed

hubble observe doesn't support --until without --since #519

michi-covalent opened this issue Mar 22, 2021 · 5 comments 路 Fixed by #792
Assignees
@ahmedaabouzied
Labels
鈱笍 area/cli Impacts the command line interface of any command in the repository. 馃憤 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble.

Comments

@michi-covalent
Copy link
Collaborator

right now --until flag seems to get ignored if --since is not specified. i was expecting --since to get set to zero if only --until flag is specified 馃

slack discussion: https://cilium.slack.com/archives/CQRL1EPAA/p1616170452006600
@michi-covalent michi-covalent added the 鈱笍 area/cli Impacts the command line interface of any command in the repository. label Mar 22, 2021
@glibsm glibsm added the 馃憤 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. label Mar 22, 2021
@ahmedaabouzied
Copy link

Is this still relevant? Can I pick it up?

@rolinh
Copy link
Member

rolinh commented Aug 12, 2022

Yes, this is still relevant. Thanks for volunteering @ahmedaabouzied, I'll assign this issue to you!

@chowmean
Copy link

Hi, if this is not WIP, can I take it up? @rolinh

@kaworu
Copy link
Member

kaworu commented Sep 13, 2022

@ahmedaabouzied are ou working on this?

@ChrsMark ChrsMark mentioned this issue Oct 1, 2022
Merged
@ChrsMark
Copy link
Contributor

ChrsMark commented Oct 1, 2022

Hey folks! Not sure what is the status and the assignment of this issue but I took the chance to push a fix for it at #792. I opened the PR as draft so feel free to close+ignore it if other people are already working on it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmedaabouzied ahmedaabouzied

Labels
鈱笍 area/cli Impacts the command line interface of any command in the repository. 馃憤 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix observe command not supporting --until without --since ChrsMark/hubble
7 participants
@kaworu @glibsm @rolinh @chowmean @ChrsMark @michi-covalent @ahmedaabouzied