Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix observe command not supporting --until without --since #792

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix observe command not supporting --until without --since #792

merged 1 commit into from
Oct 4, 2022

Conversation

ChrsMark
Copy link
Contributor

@ChrsMark ChrsMark commented Oct 1, 2022

At the moment, hubble observe command ignores --until flag if --since is not specified. It would be expected --since flag to not be a hard requirement for --until flag to be used on its own.

This patch makes --until flag to be consider without having --since flag as a prerequisite.

Fixes #519

Signed-off-by: ChrsMark chrismarkou92@gmail.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 1, 2022
@ChrsMark ChrsMark mentioned this pull request Oct 1, 2022
Closed
rolinh
rolinh reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the comment, see below.

cmd/observe/agent_events.go Outdated Show resolved Hide resolved
cmd/observe/agent_events_test.go Show resolved Hide resolved
@kaworu kaworu added the release-note/misc This PR makes changes that have no direct user impact. label Oct 3, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 3, 2022
@ChrsMark ChrsMark marked this pull request as ready for review October 3, 2022 18:12
@ChrsMark ChrsMark requested a review from a team as a code owner October 3, 2022 18:12
@ChrsMark ChrsMark requested review from michi-covalent and removed request for a team October 3, 2022 18:12
@rolinh
Copy link
Member

rolinh commented Oct 4, 2022

The changes look good to me, thanks! Would you mind squashing your two commits?

@ChrsMark
Fix observe command not supporting --until without --since
30f8f10 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the pr/fix_until_ignored_whithout_since branch from 9909183 to 30f8f10 Compare October 4, 2022 08:02
michi-covalent
michi-covalent approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 4, 2022
@michi-covalent michi-covalent merged commit ae16426 into cilium:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hubble observe doesn't support --until without --since
4 participants
@ChrsMark @rolinh @kaworu @michi-covalent