Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker build failing #79

Closed
michi-covalent opened this issue Feb 5, 2020 · 2 comments · Fixed by #80
Closed

docker build failing #79

michi-covalent opened this issue Feb 5, 2020 · 2 comments · Fixed by #80

Comments

@michi-covalent
Copy link
Collaborator

% docker build .
Sending build context to Docker daemon  77.13MB
Step 1/10 : FROM docker.io/library/golang:1.12.8-alpine3.10 as builder
 ---> 5b92ed72e216
Step 2/10 : WORKDIR /go/src/github.com/cilium/hubble
 ---> Using cache
 ---> 803a6b64b66d
Step 3/10 : RUN apk add --no-cache binutils git make  && go get -d github.com/google/gops  && cd /go/src/github.com/google/gops  && git checkout -b v0.3.6 v0.3.6  && go install  && strip /go/bin/gops
 ---> Using cache
 ---> 300fc80b6d93
Step 4/10 : COPY . .
 ---> 90be6e428192
Step 5/10 : RUN make clean && make hubble
 ---> Running in 653ebfb40c6c
rm -f hubble
go build -mod=vendor -o hubble
build flag -mod=vendor only valid when using modules
make: *** [Makefile:11: hubble] Error 1
The command '/bin/sh -c make clean && make hubble' returned a non-zero code: 2
michi-covalent added a commit that referenced this issue Feb 5, 2020
This gets rid of the error:

    build flag -mod=vendor only valid when using modules

Closes #79

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@glibsm
Copy link
Member

glibsm commented Feb 5, 2020

Did quay notify anyone or was this found by accident?

@michi-covalent
Copy link
Collaborator Author

i was trying to build the image locally. right now quay doesn't really notify anything.

one thing we can do is to do docker build . as a part of the build in github actions.

michi-covalent added a commit that referenced this issue Feb 5, 2020
This gets rid of the error:

    build flag -mod=vendor only valid when using modules

Closes #79

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants