Don't set --last if --input-file is specified #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
michi-covalent
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
force-pushed
the
pr/michi/input-file-struggle
branch
from
972e779
to
46bd778
Compare
|
looking into the test failure 😶🌫️ |
michi-covalent
force-pushed
the
pr/michi/input-file-struggle
branch
from
46bd778
to
f59124b
Compare
chancez
reviewed
Jul 26, 2023
| @@ -174,3 +174,12 @@ func Test_getFlowsRequest_ExperimentalFieldMask_non_json_output(t *testing.T) { | |||
| err := handleFlowArgs(os.Stdout, filter, false) | |||
| assert.ErrorContains(t, err, "not compatible") | |||
| } | |||
|
|
|||
| // Don't set the number flag in GetFlowsRequest if --input-file is specified | |||
| func Test_getFlowsRequestWithInputFile(t *testing.T) { | |||
There was a problem hiding this comment.
Can we have a test where --last is used with --input-file too?
There was a problem hiding this comment.
good idea 🥰
Don't set --last to 20 if --input-file flag is specified to preserve the previous default behavior of processing all the flows from stdin. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/input-file-struggle
branch
from
f59124b
to
d394475
Compare
chancez
approved these changes
Jul 26, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't set --last to 20 if --input-file flag is specified to preserve the previous default behavior of processing all the flows from stdin.