renovate: Use allowedVersions to limit updates to stable branches #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
added
🧹 kind/cleanup
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
This was referenced Oct 10, 2023
|
@aanm mentioned we could also still use The approach I've taken is a bit more explicit, and will require changing the Go/Alpine versions as we update the matchBaseBranches. The approach he's mentioned is less explicit, but basically would only require us to update the matchBaseBranches. Each has pros/cons. I'm open to suggestions on which way we would like to do it. |
rolinh
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
approved these changes
Oct 11, 2023
lambdanis
approved these changes
Oct 11, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchUpdateTypesis the wrong option for limiting updates in the stable branch. When I wrote this config, it was based off Cilium's config, which I looked at, and has since changed to usingallowedVersions. It seems we're all slowly learning the lesson of how to correctly configure renovate. Ref #1239 (comment)