Switch protobuf module to google.golang.org/protobuf #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
🧹 kind/cleanup
gandro
approved these changes
Dec 9, 2020
| t, err := ptypes.Timestamp(ts) | ||
| if err != nil || t.IsZero() { | ||
| func fmtTimestamp(ts *timestamppb.Timestamp) string { | ||
| if !ts.IsValid() { |
There was a problem hiding this comment.
Very nice find. For other reviewers: IsValid checks for nil and invalid timestamps both.
maintainer-s-little-helper
bot
added
ready-to-merge
tklauser
added
the
needs-rebase
MaybeTime is only used in fmtTimestamp. The timer.Time passed to it can never be nil so the "N/A" case is never hit (except in tests). Thus, pull the time.Format call directly into fmtTimestamp. Note that MaybeTime is an exported func, but there are no known external users, so it should be safe to drop it. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
kaworu
approved these changes
Dec 10, 2020
Update all users of the deprecated github.com/golang/protobuf module to google.golang.org/protobuf Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/protobuf-apiv2
branch
from
4bd44e5
to
8b57224
Compare
tklauser
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a preparatory cleanup removing
pkg/printer.MaybeTime. Note that this is an exported func, but there are no known external users, so it should be safe to drop it.The second commit switches from the deprecated
github.com/golang/protobufmodule togoogle.golang.org/protobuf.