cmd/observer: add support for agent event sub-type filters #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase test coverage and ensure the changes in the successive commits won't break existing functionality. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Instead of falling through to the default case, move the default case out of the switch statement. Preparatory refactoring for parsing agent event subtype in the next commit which will require adding an additional case to the switch statement for which we want to fall back to numeric parsing as well. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Allow to filter by agent event sub-type using "-t agent:<sub-type>". Unfortunately, the sub-type strings in the monitor API are free form descriptions and contain uppercase characters and spaces. This makes them cumbersome and not user-friendly for CLI filter arguments. Thus, keep our own, cleaned values for these sub-types and make sure in TestAgentEventSubTypeMap that they are kept in sync with monitorAPI.AgentNotifications. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
⌨️ area/cli
gandro
approved these changes
Jan 14, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit add test coverage for the functionality changed in the successive commits.
The second commit does some small refactoring to avoid duplicating numeric sub-type parsing.
The third commit introduces the actual agent event sub-type filtering. One caveat was that the monitor API (
github.com/cilium/cilium/pkg/monitor/api) doesn't provide the sub-type strings a form which would be convenient for CLI arguments (i.e. they contain spaces). Thus,github.com/cilium/cilium/pkg/monitor/api.AgentNotificationsis duplicated incmd/observein more convenient form. A test is added to ensure the two maps are kept in sync.See individual commit messages for more details.