Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/node: fix completion of output flag #466

Merged
merged 1 commit into from
Jan 18, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/node/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,24 @@ func newListCommand(vp *viper.Viper) *cobra.Command {
},
}

// formatting flags
formattingFlags := pflag.NewFlagSet("Formatting", pflag.ContinueOnError)
formattingFlags.StringVarP(
&listOpts.output, "output", "o", "table",
`Specify the output format, one of:
json: JSON encoding
table: Tab-aligned columns
wide: Tab-aligned columns with additional information`)
listCmd.Flags().AddFlagSet(formattingFlags)

// advanced completion for flags
listCmd.RegisterFlagCompletionFunc("output", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return []string{
"json",
"table",
"wide",
}, cobra.ShellCompDirectiveDefault
})
listCmd.Flags().AddFlagSet(formattingFlags)

listCmd.SetUsageTemplate(template.Usage(formattingFlags, config.ServerFlags))
return listCmd
Expand Down