Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add CodeQL analysis #475

Merged
merged 1 commit into from
Feb 2, 2021
Merged

ci: Add CodeQL analysis #475

merged 1 commit into from
Feb 2, 2021

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Feb 1, 2021

This adds CodeQL analysis to Hubble, similar to cilium/cilium#14514.

@twpayne
ci: Add CodeQL analysis
0293ed4 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne added 🤖 area/CI Impacts the testing / continuous integration testing of the project. release-note/misc This PR makes changes that have no direct user impact. labels Feb 1, 2021
@kaworu
Copy link
Member

kaworu commented Feb 1, 2021

Thanks @twpayne for the PR! Is the "analysis not found" expected? https://github.com/cilium/hubble/pull/475/checks?check_run_id=1807367595

@twpayne
Copy link
Contributor Author

twpayne commented Feb 1, 2021

Nope, definitely not expected. With these CI changes, you only get to debug them once you push a branch :)

@kaworu
Copy link
Member

kaworu commented Feb 1, 2021

So what would be the way to make forward progress on this?

@twpayne
Copy link
Contributor Author

twpayne commented Feb 1, 2021

So what would be the way to make forward progress on this?

I need to do some debugging :)

@twpayne
Copy link
Contributor Author

twpayne commented Feb 1, 2021

I think this is just because this is the first CodeQL analysis for this repo, so there's no other analysis to compare with to find what's been fixed or newly introduced. Relevant doc.

@kaworu
Copy link
Member

kaworu commented Feb 2, 2021 •
edited

I think this is just because this is the first CodeQL analysis for this repo, so there's no other analysis to compare with to find what's been fixed or newly introduced. Relevant doc.

That make sense. What we could do is merge this PR, and then you make another (dummy or cosmetic) PR to see if everything work as expected. How does that sound?

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 2, 2021
@gandro gandro merged commit 7b49e9e into master Feb 2, 2021
@gandro gandro deleted the pr/twpayne/codeql branch February 2, 2021 10:35
@twpayne
Copy link
Contributor Author

twpayne commented Feb 2, 2021

That make sense. What we could do is merge this PR, and then you make another (dummy or cosmetic) PR to see if everything work as expected. How does that sound?

Good idea. I've rebased #474 on top of this, which should serve the purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

Assignees
No one assigned
Labels
🤖 area/CI Impacts the testing / continuous integration testing of the project. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twpayne @kaworu @gandro