Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/observe: mark deprecated output flags as deprecated #506

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Mar 9, 2021

This hides the flags "json", "compact" and "dict" from the help output and prints the replacement flag to use instead. E.g. for "json":

$ hubble observe --json
Flag --json has been deprecated, use '--output json' instead

This hides the flags "json", "compact" and "dict" from the help output
and prints the replacement flag to use instead. E.g. for "json":

    $ hubble observe --json
    Flag --json has been deprecated, use '--output json' instead

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added ⌨️ area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Mar 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 9, 2021
@glibsm
Copy link
Member

glibsm commented Mar 9, 2021

I think this is not a misc note, since this is something user-facing and should appear as a minor release note.

@rolinh rolinh added release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. and removed release-note/misc This PR makes changes that have no direct user impact. labels Mar 9, 2021
@rolinh rolinh merged commit a3f19d9 into master Mar 9, 2021
@rolinh rolinh deleted the pr/rolinh/observe-deprecate-old-output-flags branch March 9, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants