compact: Always print original source on the left #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
michi-covalent
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
this is a breaking change since it modifies an existing format. we could introduce another format instead but i wasn't sure if it's worth it. |
rolinh
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
this is a breaking change since it modifies an existing format. we could introduce another format instead but i wasn't sure if it's worth it.
It is indeed a breaking change but I'm not too worried about it. Users wanting to process the hubble observe output likely use a format that is more appropriate for this purpose such as JSON. I think that this change makes the output much more readable so imho it is for the better. We should make it clear in the release notes that this is a breaking change though.
maintainer-s-little-helper
bot
added
the
ready-to-merge
gandro
approved these changes
Apr 22, 2021
michi-covalent
force-pushed
the
pr/michi/print
branch
from
36f97b0
to
a23e781
Compare
Keep the original source on the left and use "<-" for reply packets. If IsReply field is not set, the direction is set to "<>". Before: ``` 2021-04-22T03:51:42Z: 10.168.0.11:33192 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: SYN) 2021-04-22T03:51:42Z: kube-system/kube-dns-5d54b45645-p9kvw:8081 -> 10.168.0.11:33192 to-stack FORWARDED (TCP Flags: SYN, ACK) 2021-04-22T03:51:42Z: 10.168.0.11:33192 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: ACK) 2021-04-22T03:51:42Z: 10.168.0.11:33192 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: ACK, PSH) 2021-04-22T03:51:42Z: kube-system/kube-dns-5d54b45645-p9kvw:8081 -> 10.168.0.11:33192 to-stack FORWARDED (TCP Flags: ACK, PSH) 2021-04-22T03:51:42Z: kube-system/kube-dns-5d54b45645-p9kvw:8081 -> 10.168.0.11:33192 to-stack FORWARDED (TCP Flags: ACK, FIN) 2021-04-22T03:51:42Z: 10.168.0.11:33192 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: ACK, FIN) ``` After: ``` 2021-04-22T03:50:02Z: 10.168.0.11:60982 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: SYN) 2021-04-22T03:50:02Z: 10.168.0.11:60982 <- kube-system/kube-dns-5d54b45645-p9kvw:8081 to-stack FORWARDED (TCP Flags: SYN, ACK) 2021-04-22T03:50:02Z: 10.168.0.11:60982 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: ACK) 2021-04-22T03:50:02Z: 10.168.0.11:60982 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: ACK, PSH) 2021-04-22T03:50:02Z: 10.168.0.11:60982 <- kube-system/kube-dns-5d54b45645-p9kvw:8081 to-stack FORWARDED (TCP Flags: ACK, PSH) 2021-04-22T03:50:02Z: 10.168.0.11:60982 <- kube-system/kube-dns-5d54b45645-p9kvw:8081 to-stack FORWARDED (TCP Flags: ACK, FIN) 2021-04-22T03:50:02Z: 10.168.0.11:60982 -> kube-system/kube-dns-5d54b45645-p9kvw:8081 to-endpoint FORWARDED (TCP Flags: ACK, FIN) ``` Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/print
branch
from
a23e781
to
ffcd479
Compare
|
@michi-covalent do we need to "port" this patch to cilium-cli as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the original source on the left and use "<-" for reply packets.
Before:
After:
Signed-off-by: Michi Mutsuzaki michi@isovalent.com