Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage template to determine --help flags using a registration pattern #718

Merged
merged 1 commit into from
May 17, 2022

Conversation

chancez
Copy link
Contributor

@chancez chancez commented May 13, 2022

Removes the need to set the usage template per subcommand by registering
the commands which should be displayed in --help for each subcommand.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label May 13, 2022
@chancez chancez force-pushed the pr/chancez/flagset_registration branch from 55ee43e to 1673dcd Compare May 13, 2022 21:19
@glibsm glibsm added the release-note/misc This PR makes changes that have no direct user impact. label May 13, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label May 13, 2022
…n pattern

Removes the need to set the usage template per subcommand by registering
the commands which should be displayed in --help for each subcommand.

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez force-pushed the pr/chancez/flagset_registration branch from 1673dcd to e99127a Compare May 13, 2022 22:30
@kaworu kaworu requested a review from rolinh May 16, 2022 08:19
@chancez chancez marked this pull request as ready for review May 16, 2022 17:34
@chancez chancez requested a review from a team May 16, 2022 17:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 17, 2022
@rolinh rolinh merged commit a34780d into master May 17, 2022
@rolinh rolinh deleted the pr/chancez/flagset_registration branch May 17, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants