docs: Document pod/service filter prefix behavior #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slayer321
requested review from
a team and
joamaki
and removed request for
a team
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
kaworu
added
📄 area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
requested changes
Jun 7, 2022
There was a problem hiding this comment.
According to #501, there are 6 docstrings to fix (--from-pod, --pod, --to-pod and --from-service, --service, --to-service), not just --pod and --service. I also find the description too verbose. I think that something along the line of the following would be enough:
--from-pod filter Show all flows originating in the given pod name prefix ([namespace/]<pod-name>). If namespace is not provided, 'default' is used.
rolinh
reviewed
Jun 7, 2022
|
Thanks @slayer321. Could you please squash your commits before we merge the PR? |
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
slayer321
force-pushed
the
pr/slayer321/prefix-pod-service-name
branch
from
7d5495f
to
7abdb17
Compare
rolinh
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document pod/service filter prefix behavior
Fixes: #501
Signed-off-by: slayer321 sachin.maurya7666@gmail.com