Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compact: Use "ID" for security identity prefix #734

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

michi-covalent
Copy link
Collaborator

It's shorter than "identity", and still conveys enough information
about what these integers mean.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

It's shorter than "identity", and still conveys enough information
about what these integers mean.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested review from a team and joamaki and removed request for a team June 3, 2022 15:56
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jun 3, 2022
@michi-covalent michi-covalent added the release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. label Jun 3, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Jun 3, 2022
@gandro gandro removed the request for review from joamaki June 7, 2022 08:14
@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. labels Jun 7, 2022
@gandro
Copy link
Member

gandro commented Jun 7, 2022

Thanks for taking care of this! 🚀

Changing the release notes to misc, since the output it changes is not released yet.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2022
@michi-covalent michi-covalent merged commit 6714809 into master Jun 7, 2022
@michi-covalent michi-covalent deleted the pr/michi/identity-label-for-compact-output branch June 7, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants