cmd/observe: improve policy verdict output in compact mode #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
⌨️ area/cli
rolinh
requested review from
pchaigno,
a team and
joamaki
and removed request for
a team
rolinh
added a commit
to cilium/cilium
that referenced
this pull request
Jun 14, 2022
From a user perspective, it is much easier to understand the flow type when policy verdict events verdicts use the term ALLOWED instead of REDIRECTED/FORWARDED and DENIED instead of DROPPED. See also: cilium/hubble#745 Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
michi-covalent
approved these changes
Jun 14, 2022
|
lgtm! for for edit: also it might be useful to indicate direction (ingress/egress) 💭 |
Fully agreed. I think having the match type is very useful in audit mode, to narrow down what part of a policy allowed it. |
The default output (compact) makes it hard for a user to tell the different event types apart. In particular, it is hard for a user to distinguish a trace event from a policy verdict one. This commit modifies the output for policy verdict events in two ways. First, instead of printing the drop reason (which is redundant as also printed out with the dropped flow) the string 'policy-verdict' along with the policy match type string for the event (L3-Only, L3-L4, L4-Only, all, none), is displayed. Additionally, flows that are forwarded or redirected are printed as ALLOWED, those that are dropped or error as DENIED and the audit ones as AUDITED. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/surface-event-type
branch
from
3b5627f
to
53e2996
Compare
|
@gandro PTAL, I updated the output to also include the policy match type. |
|
time to ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default output (compact) makes it hard for a user to tell the
different event types apart. In particular, it is hard for a user to
distinguish a trace event from a policy verdict one.
This commit modifies the output for policy verdict events in two ways.
First, instead of printing the drop reason (which is redundant as also
printed out with the dropped flow) the string 'policy-verdict' along
with the policy match type string for the event (L3-Only, L3-L4,
L4-Only, all, none), is displayed.
Additionally, flows that are forwarded or redirected are printed as
ALLOWED, those that are dropped or error as DENIED and the audit ones as
AUDITED.
Example output from #570:
Closes: #570