compact: Add traffic direction to policy verdict events #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
requested review from
a team and
glibsm
and removed request for
a team
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
glibsm
reviewed
Jul 7, 2022
pkg/printer/printer.go
Outdated
Comment on lines
229
to
232
| api.PolicyMatchType(f.GetPolicyMatchType()).String() + " " + | ||
| f.GetTrafficDirection().String() | ||
|
|
There was a problem hiding this comment.
There are no cases when this is empty, right?
Also, minor nit comment: fmt.Sprintf would maybe be easier to read here
There was a problem hiding this comment.
yeah i think it is always set to either ingress or egress. i'll change the code to use Sprintf instead 👍
There was a problem hiding this comment.
It's either INGRESS, EGRESS or TRAFFIC_DIRECTION_UNKNOWN if unset (see here). The latter is rather verbose but I don't think it's expected to ever show up.
There was a problem hiding this comment.
TRAFFIC_DIRECTION_UNKNOWN can be set for non-policy-verdict flows. But yes, for policy verdict it should always be set to EGRESS or INGRESS.
|
sample output
|
michi-covalent
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/direction
branch
from
ee99f35
to
4bf99a8
Compare
gandro
approved these changes
Jul 11, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com