Use command path when registering flagsets #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
chancez
force-pushed
the
pr/chancez/command_flag_registration
branch
from
d5a989e
to
62374b1
Compare
Avoids conflicts when different sub-commands have the same command name. (Eg: hubble status vs hubble foobar status). Since commands paths rely on having parent-commands, we must initialize the map containing the flagsets after all sub-commands have been added. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/command_flag_registration
branch
from
62374b1
to
b18ccd4
Compare
michi-covalent
approved these changes
Jul 29, 2022
rolinh
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids conflicts when different sub-commands have the same command name.
(Eg: hubble status vs hubble foobar status).
Since commands paths rely on having parent-commands, we must initialize
the map containing the flagsets after all sub-commands have been added.
This was something I discovered after trying to add new sub-commands that have the same name as other sub-sub-commands.