Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add traceID filter #795

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Add traceID filter #795

merged 2 commits into from
Oct 13, 2022

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Oct 7, 2022

PR cilium/cilium#21551 added support for filtering by trace ID in hubble, makes it possible to filter by trace ID in hubble CLI.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 7, 2022
@kaworu kaworu added :basecamp: needs-rebase This PR needs to be rebased because it has merge conflicts. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble. labels Oct 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 10, 2022
@chancez chancez marked this pull request as ready for review October 10, 2022 17:30
@chancez chancez requested review from a team as code owners October 10, 2022 17:30
@chancez chancez requested review from rolinh and removed request for a team October 10, 2022 17:30
@kaworu kaworu removed the :basecamp: needs-rebase This PR needs to be rebased because it has merge conflicts. label Oct 11, 2022
kaworu
kaworu approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chancez the patch LGTM. Small nit on the way: about the first commit ("go.{mod,sum},vendor: Update cilium") can we have the Cilium version in the commit message please (e.g. 612202f)? Make it easier to track without having to look at the diff.

@kaworu kaworu added the 🌟 kind/feature This introduces new functionality. label Oct 11, 2022
@chancez
Copy link
Contributor Author

chancez commented Oct 11, 2022

@kaworu Sure, though it's just latest master, not a specific version. I could update the message to say why we're using master (to pick up the traceID field) at least.

@chancez
go.{mod,sum},vendor: Update cilium to latest master
5357378 
Also updates flow tests to exclude trace-sock message type

We need an updated cilium from master so that we can pull in the newest
protobufs with the TraceContext field.

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
rolinh
rolinh approved these changes Oct 12, 2022
View reviewed changes
cmd/observe/flows.go Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 12, 2022
@chancez
Add trace-id filter
1265fbd 
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@gandro gandro merged commit e65862c into cilium:master Oct 13, 2022
@chancez chancez deleted the pr/chancez/trace_id_filter branch October 13, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
🌟 kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR introduces functionality that users may find relevant to operating Hubble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chancez @kaworu @rolinh @gandro