Update Go to 1.19.3, golangci-lint to 1.50.1 #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tklauser
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Nov 8, 2022
This fixes the following contextcheck linter error: Function `newIOReaderClient` should pass the context parameter (contextcheck) Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/update-go-1.19.3
branch
from
2e96b3c
to
203a7d8
Compare
gandro
approved these changes
Nov 8, 2022
|
Seems the linter is a bit more sensitive towards package doc comments? https://github.com/cilium/hubble/actions/runs/3420125081/jobs/5694532263 |
This will re-enable the contextcheck linter for Go ≥ 1.18. Update Go compatibility for the gosimple linter to 1.19. This should have been done in commit 0e85e38 ("Update Go to 1.19"). Remove the deadcode, structcheck and varcheck linters that have been deprecated since golangci-lint v1.49.0. Disable the revive linter warnings for missing package level godoc comments. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/update-go-1.19.3
branch
from
203a7d8
to
08067b0
Compare
"Fixed" by ignoring the warning about missing package-level godocs for now. I'll send a followup PR to add all missing godoc comments. |
michi-covalent
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.