cmd/observe: fix stdin reading from file redirection #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
the
release-note/bug
This comment was marked as resolved.
This comment was marked as resolved.
|
Nevermind my above comment. |
The `hubble observe` command could only read from stdin when being piped to, e.g. `cat sample.json | hubble observe` but not via file redirect such as `hubble observe < sample.json`. This commit makes the latter possible. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/fix-stdin-redirection
branch
from
1a8e686
to
3d510aa
Compare
|
@gandro I've updated the patch. I think checking that stdin is not character device is sufficient. |
gandro
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hubble observecommand could only read from stdin when being piped to, e.g.cat sample.json | hubble observebut not via file redirect such ashubble observe < sample.json. This commit makes the latter possible.Fix: #809