cmd: Make -o json an alias for -o jsobpb
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the old deprecated JSON output and fully replaces it with the newer JSONPB output (based on proto3's json mapping). This is a breaking change, users of `-o json` will have to adopt the output parsing slightly: Each emitted object is now wrapped in a `GetFlowsResponse`, which means that the flow object (the root of the previous JSON output) is now accessible via the `.flow` attribute. For example, a query of the form `hubble observe -o json | jq .source.labels` now needs to be written as `hubble observe -o json | jq .flow.source.labels`. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
⌨️ area/cli
kaworu
approved these changes
Dec 19, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the old deprecated JSON output and fully replaces it with the newer JSONPB output (based on proto3's json mapping).
This is a breaking change, users of
-o jsonwill have to adopt the output parsing slightly: Each emitted object is now wrapped in aGetFlowsResponse, which means that the flow object (the root of the previous JSON output) is now accessible via the.flowattribute.For example, a query of the form
hubble observe -o json | jq .source.labelsnow needs to be written ashubble observe -o json | jq .flow.source.labels.