Add hubble observe flows #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
chancez
force-pushed
the
pr/chancez/hubble_observe_alias
branch
2 times, most recently
from
fe137cd
to
9d05514
Compare
Hubble observe is now an alias for `hubble observe flows`. The only major difference is the help text for `hubble observe` is now briefer and indicates it is an alias for `hubble observe flows`. Additionally, while refactoring, I removed the flow formatting flags from the general formatting flagset and just moved it to it's own flagset. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/hubble_observe_alias
branch
from
9d05514
to
cf7f8e4
Compare
kaworu
added
⌨️ area/cli
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
kaworu
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Thanks a lot for tackling this @chancez! 🙏 Tested and the patch LGTM to me as well.
One funny thing I noticed is that hubble observe flows already works before this patch (I guess the missing subcommand invoke the parent because hubble observe foo also show flows).
tklauser
approved these changes
Jan 17, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
@chancez I think this PR broke the shorthand flags: Only occurs on master, v0.11 is fine. |
|
I think it's not just shorthand flags; formatting flags seem to be broken: EDIT: selector flags as well it seems |
|
@rolinh Ah. I guess tests and my manual usage weren't using these flags. Let's revert and I can try again. |
This was referenced Jan 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubble observe is now an alias for
hubble observe flows. The only major difference is the help text forhubble observeis now briefer and indicates it is an alias forhubble observe flows. Additionally, while refactoring, I removed the flow formatting flags from the general formatting flagset and just moved it to it's own flagset.Fixes #543