ipallocator: Fix broken IPv6 conversion with leading zeros #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where GetIndexedIP would fail to produce correct IPv6 addresses if the IPv6 address contains leading zeros. This bug has been fixed in upstream for a while: kubernetes/utils#145 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
tklauser
approved these changes
Oct 25, 2021
gandro
added a commit
to gandro/cilium
that referenced
this pull request
Oct 26, 2021
This fixes a bug where IPv6 addresses with leading zeros (such as e.g. `fd:11::/64`) were not supported by the IP allocator. See also: cilium/ipam#4 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
kkourt
pushed a commit
to cilium/cilium
that referenced
this pull request
Oct 27, 2021
This fixes a bug where IPv6 addresses with leading zeros (such as e.g. `fd:11::/64`) were not supported by the IP allocator. See also: cilium/ipam#4 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
michi-covalent
pushed a commit
to cilium/cilium
that referenced
this pull request
Oct 27, 2021
This fixes a bug where IPv6 addresses with leading zeros (such as e.g. `fd:11::/64`) were not supported by the IP allocator. See also: cilium/ipam#4 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where GetIndexedIP would fail to produce correct IPv6 addresses if the IPv6 address contains leading zeros.
As a consequence, perfectly valid IPv6 pod CIDRs like
fd:11::/64could not be used.This bug has been fixed in upstream for a while: kubernetes/utils#145
Ideally, we sync this package with upstream, as there are likely more such bugs that we have not fixed yet. But it seem upstream has moved quite far from our implementation and moved packages around, so it's unclear what changes we have applied on our side only.