add a command to list kernel tags and pull kernels built by little-vm-helper-images #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prepare the addition of two new commands: get and catalog that won't use the flag and thus we can no longer set the flag as persistent on the kernels function. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/add-get-kernel
branch
from
e09bf8d
to
8fd3986
Compare
joestringer
reviewed
Apr 12, 2024
This command allows to list the built kernels by LVHI. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
This one uses the google/go-containerregistry (or crane) library that can perform actions without a docker daemon running. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/add-get-kernel
branch
from
8fd3986
to
8a969ea
Compare
This was referenced Apr 15, 2024
joestringer
approved these changes
Apr 15, 2024
Allow the user to provide the repo and provide examples for the CI repository, rather than hardcoding lvh org OCI repos and CI flag. Signed-off-by: Joe Stringer <joe@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could also replace the
lvh images pullimplementation so that it doesn't require a docker daemon (can also remove the dependency).