Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace proxylib builder image #308

Closed
sayboras opened this issue Aug 23, 2023 · 0 comments · Fixed by #420
Closed

Replace proxylib builder image #308

sayboras opened this issue Aug 23, 2023 · 0 comments · Fixed by #420
Assignees
@sayboras

Comments

@sayboras
Copy link
Member

Description

Currently, the proxylib builder image is from upstream quay.io/cilium/cilium-builder image, which can cause some problem for auto upgrade.

It will be better to change to something else, which is smaller and also managed by renovate bot.

proxy/Dockerfile

Lines 6 to 8 in f4eb004

# Common Builder image used in cilium/cilium
# We need gcc for cgo cross-compilation at least, we can swap to something smaller later on
ARG PROXYLIB_BUILDER=quay.io/cilium/cilium-builder:832f86bb0f7c7129c1536d5620174deeec645117@sha256:6dbac9f9eba3e20f8edad4676689aa8c11b172035fe5e25b533552f42dea4e9a

@sayboras sayboras mentioned this issue Aug 23, 2023
Merged
@sayboras sayboras mentioned this issue Oct 26, 2023
Merged
sayboras added a commit to sayboras/proxy that referenced this issue Oct 26, 2023
@sayboras
docker: Use golang image as proxylib builder
ca45583 
Instead of relying on builder image, we can just use golang image as
base, and install a couple of packages for cross compliation. The
benefit to have auto-upgrade capability from renovate bot.

Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Oct 28, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
db088ce 
Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Oct 29, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
92bf9e0 
Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Oct 29, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
bcd48f8 
Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Oct 29, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
d993efb 
Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Oct 29, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
369a57c 
Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras self-assigned this Oct 29, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
2a39bd5 
Fixes: #308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Nov 21, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
4cca6ca 
Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Nov 21, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
0b3ad36 
[upstream commit 2a39bd5]

Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this issue Nov 21, 2023
Closed
sayboras added a commit to sayboras/proxy that referenced this issue Nov 21, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
667c5b7 
[upstream commit 2a39bd5]

Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Nov 21, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
d160c10 
[upstream commit 2a39bd5]

Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Nov 21, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
0821ca4 
[upstream commit 2a39bd5]

Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this issue Nov 26, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
1079baf 
[upstream commit 2a39bd5]

Fixes: cilium#308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this issue Nov 27, 2023
@sayboras
docker: Use envoy builder image as proxylib builder
a714b47 
[upstream commit 2a39bd5]

Fixes: #308

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sayboras sayboras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker: Use envoy builder image as proxylib builder sayboras/proxy
1 participant
@sayboras