Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: sign container image with cosign #212

Merged
merged 2 commits into from
May 17, 2023
Merged

ci: sign container image with cosign #212

merged 2 commits into from
May 17, 2023

Conversation

mhofstetter
Copy link
Member

This PR implements container image signing using cosign.

@mhofstetter mhofstetter force-pushed the pr/mhofstetter/cosign branch 3 times, most recently from 03ca91f to 36b095e Compare May 15, 2023 12:07
@mhofstetter
Copy link
Member Author

Successful run of build with pull_request instead of pull_request_target: https://github.com/cilium/proxy/actions/runs/4979997112/jobs/8912321483?pr=212

@mhofstetter mhofstetter marked this pull request as ready for review May 15, 2023 12:09
@mhofstetter mhofstetter requested a review from sayboras May 15, 2023 12:09
This commit implements container image signing using cosign.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit introduces automated version management of
kubernetes-sigs/bom with renovate.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI image signing might not be required, but we can revisit again depending on how flaky this signing process is. LGTM ✔️

@sayboras sayboras merged commit 714ec49 into main May 17, 2023
3 checks passed
@sayboras sayboras deleted the pr/mhofstetter/cosign branch May 17, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants