Implement --filter-non-skb-funcs #355
Merged
+75
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
commented
Apr 19, 2024
jschwinger233
force-pushed
the
gray/trace-non-skb-funcs
branch
from
fae4f99
to
ab70ae0
Compare
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Usage: --filter-non-skb-funcs xfrm_state_look_at Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
gray/trace-non-skb-funcs
branch
from
ab70ae0
to
1a048d0
Compare
brb
reviewed
Apr 19, 2024
| u64 stackid = get_stackid(ctx); | ||
|
|
||
| struct sk_buff **skb = bpf_map_lookup_elem(&stackid_skb, &stackid); | ||
| if (skb && *skb) |
There was a problem hiding this comment.
You are right, it's MS Copilot! Let me fix it.
There was a problem hiding this comment.
Okay.. you merged ...
brb
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enabling --filter-track-skb-by-stackid, we can track kernel functions without skb parameter.
For example, to observe xfrm state lookup, we can use command:
pwru --filter-non-skb-funcs xfrm_state_look_at,xfrm_state_lookup,xfrm_state_lookup_byaddr,xfrm_state_lookup_byspi.Also, this is another step towards "tailcall tracing". This PR allows us to attach bpf helpers (that are probably not skb functions). By fetching bpf helpers' caller pc and converting pc into symbol, we'll see the bpf prog name.
Signed-off-by: Zhichuan Liang gray.liang@isovalent.com