-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-arrange output columns #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gray <gray.liang@isovalent.com>
Because it has variant length. Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
Also strip 0x prefix. Signed-off-by: gray <gray.liang@isovalent.com>
ifname can be as long as 16 bytes, plust len of ifindex len(str(1<<32))=10, it should be at least 26. However, 16 is enough for most of situations, so let's make it 16. Also center align this column out of aesthetics. Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
Actually it's a uint32, but let's make it 5 that fits most scenarios. Signed-off-by: gray <gray.liang@isovalent.com>
Still, it's a u32, but let's treat it as u16 for most cases. Signed-off-by: gray <gray.liang@isovalent.com>
So that the following FUNC can be aligned Signed-off-by: gray <gray.liang@isovalent.com>
Signed-off-by: gray <gray.liang@isovalent.com>
Closed
Signed-off-by: gray <gray.liang@isovalent.com>
Otherwise it's hard to distinguish 00000000 from 08000000. Signed-off-by: gray <gray.liang@isovalent.com>
brb
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
pwru --output-meta --output-tuple
now is like:Comparing to original output, now it shows all data with less width in a clearer way:
Original:
Now: