Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cilium/ebpf library to 0.9.2 #94

Closed
wants to merge 1 commit into from

Conversation

vincentmli
Copy link

cilium/ebpf 0.9.2 has link.K(ret)probeMulti() API added by @mmat11, bringing blazingly-fast bulk kprobe attachments to kernels 5.18 and newer

this API should speed up pwru bulk skb function kprobe attachment

Signed-off-by: Vincent Li v.li@f5.com

@vincentmli
Copy link
Author

@brb maybe you can merge the cilium/ebpf library update first in master, then I can work on the kprobe multi based on the new master? I don't want to tie this simple cilium/ebpf library update work with the kprobe multi attach work since the later may take me some time.

@brb
Copy link
Member

brb commented Sep 22, 2022

@vincentmli Thanks for the PR. The build error is valid:

please run 'go mod tidy && go mod vendor', and submit your changes

cilium/ebpf 0.9.2 has link.K(ret)probeMulti() API added by @mmat11,
bringing blazingly-fast bulk kprobe attachments to kernels 5.18 and newer

this API should speed up pwru bulk skb function kprobe attachment

Signed-off-by: Vincent Li <v.li@f5.com>
@vincentmli
Copy link
Author

I just ran 'go mod tidy && go mod vendor' to update the commit

@brb
Copy link
Member

brb commented Sep 22, 2022

Hmm, still failing.

@vincentmli
Copy link
Author

hm, weird still complains after I ran go mod tidy ; go mod vendor, git commit and rebase to update the commit

please run 'go mod tidy && go mod vendor', and submit your changes
Error: Process completed with exit code 1.

@vincentmli
Copy link
Author

my go version if that matters

root@vli-cilium-dev:/home/vincent/go/src/github.com/vincentmli/pwru# go version
go version go1.19.1 linux/amd64

@brb
Copy link
Member

brb commented Sep 22, 2022

Let's close in favor of #95.

@brb brb closed this Sep 22, 2022
@vincentmli
Copy link
Author

run the command in my local branch having no problem

root@vli-cilium-dev:/home/vincent/go/src/github.com/vincentmli/pwru# go mod tidy
root@vli-cilium-dev:/home/vincent/go/src/github.com/vincentmli/pwru# go mod vendor
root@vli-cilium-dev:/home/vincent/go/src/github.com/vincentmli/pwru# go mod verify
all modules verified

@vincentmli vincentmli deleted the vli-ebpf-update branch September 22, 2022 16:46
@brb
Copy link
Member

brb commented Sep 22, 2022

run the command in my local branch having no problem

Please check my PR - it has more files. You might have forgotten to commit some.

@vincentmli
Copy link
Author

Thanks! I ran git commit -a to add the commit, maybe that could still miss something, anyway, will keep that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants