Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead links in the Getting Started section of the README #1653

Closed
paularah opened this issue Oct 25, 2023 · 4 comments · Fixed by #1657
Closed

Dead links in the Getting Started section of the README #1653

paularah opened this issue Oct 25, 2023 · 4 comments · Fixed by #1657
Assignees
@paularah
Labels
area/documentation Improvements or additions to documentation

Comments

@paularah
Copy link
Contributor

There are dead links in the "Getting Started" section of the README. The links probably refer to an older version of the docs.

I can open a PR for this
@mtardy
Copy link
Member

mtardy commented Oct 26, 2023 •
edited

hey! Thanks for the PR, I think you submitted your PR locally on your fork (like you ask to merge on your fork not against the main repo as it should propose by default 🤔), feel free to open a PR against the cilium/tetragon repository from your fork and we'll merge it!

@mtardy mtardy added the area/documentation Improvements or additions to documentation label Oct 26, 2023
@mtardy
Copy link
Member

mtardy commented Oct 26, 2023

Related to #1620

@paularah paularah mentioned this issue Oct 26, 2023
Merged
@paularah
Copy link
Contributor Author

whoopsie 🫢. That slipped past me.

mtardy pushed a commit that referenced this issue Oct 26, 2023
@paularah @mtardy
doc: replace dead links in README.md
22b8dd2 
There are dead links in the Getting Started section of the README. 

This patch fixes this by:

1. Replacing all the dead links with the corresponding updated link in the documentation. 

Fixes: #1653

Signed-off-by: Paul Arah <paularah.self@gmail.com>
@mtardy
Copy link
Member

mtardy commented Oct 26, 2023

Thanks a lot for the fix! 🎉 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paularah paularah

Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: replace dead links in README.md
2 participants
@mtardy @paularah