Simplify tetra and tetragon build without CGO, add binary stripping and improve Makefile #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
kind/enhancement
Previously tetra on Linux was importing the tracingpolicy package that was importing pkg/bpf which was using CGO. The CGO dependency was removed so we don't need to split between dynamic and static compilation anymore. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
- use JOBS on the local BPF build - remove docs aliases - remove image-clang-arm because the clang is multi-arch - document options of the Makefile - move variables set to the top of the file Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Build a common GO_BUILD variable to be used by all target building Go progs. Also add binary stripping by default as it doesn't affect late debugging (stack traces and gops) and reduce the size of binaries: approximately tetra 37Mo -> 25Mo and tetragon 74Mo -> 51Mo. Use new option DEBUG=1 to remove optimizations and stripping. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/makefile-go-build
branch
from
10ff183
to
ca59980
Compare
mtardy
commented
Jul 24, 2023
| @echo ' JOBS - number of jobs to run for BPF compilation (default to nproc)' | ||
| @echo ' EXTRA_GO_BUILD_LDFLAGS - extra flags to pass to the Go linker' | ||
| @echo ' EXTRA_GO_BUILD_FLAGS - extra flags to pass to the Go builder' | ||
| @echo ' EXTRA_GO_BUILD_FLAGS - extra flags to pass to the Go builder' |
There was a problem hiding this comment.
sad copy pasting here, wanted to add EXTRA_TESTFLAGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1077 and #1164.
For #1164, removing CGO will force the builder to use pure Go implementation for net and user.
See individual commits.