gha: add pr-validation GH action #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action validates PRs based on labels. It blocks PRs that have a dont-merge/* label, and blocks PRs that do not have a release-note/* labe. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Do you think all PRs should be labeled with some sort of release-note label? |
yes. that's the point of this PR. It can be |
michi-covalent
approved these changes
Aug 26, 2023
|
Could we maybe ignore bot-related PR for those validations? Not sure we need release notes for deps bumps, for example #1397. I see two things:
|
|
we should just configure renovate to add a label, maybe |
mtardy
added a commit
that referenced
this pull request
Sep 5, 2023
See #1384 (comment) and #1384 (comment). Signed-off-by: Mahé <mahe.tardy@gmail.com>
mtardy
added a commit
that referenced
this pull request
Sep 5, 2023
See #1384 (comment) and #1384 (comment). Signed-off-by: Mahé <mahe.tardy@gmail.com>
mtardy
added a commit
that referenced
this pull request
Sep 6, 2023
See #1384 (comment) and #1384 (comment). Signed-off-by: Mahé <mahe.tardy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action validates PRs based on labels.
It blocks PRs that have a dont-merge/* label, and blocks PRs that do not have a release-note/* labe.