Use a message copy to apply fieldFilters in exec events #1432
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
the
release-note/bug
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
As we keep them in the process cache, removing fields may affect the correctness of the process cache. In order to fix that, we create a copy of the event and apply fieldFilters only on the copy. FIXES: #1428 Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
tpapagian
force-pushed
the
pr/apapag/no_fieldfilter_exec
branch
from
a81851a
to
0d85e0d
Compare
willfindlay
approved these changes
Sep 5, 2023
willfindlay
added a commit
that referenced
this pull request
Nov 1, 2023
We encountered another segfault similar to the one fixed in #1432. This time, it's related to the pid field in exit events. Fix this by making a copy of the exit event before filtering. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added a commit
that referenced
this pull request
Nov 1, 2023
We encountered another segfault similar to the one fixed in #1432. This time, it's related to the pid field in exit events. Fix this by making a copy of the exit event before filtering. Also optimize copying logic to only perform the copy when absolutely necessary. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added a commit
that referenced
this pull request
Nov 2, 2023
We encountered another segfault similar to the one fixed in #1432. This time, it's related to the pid field in exit events. Fix this by making a copy of the exit event before filtering. Also optimize copying logic to only perform the copy when absolutely necessary. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added a commit
that referenced
this pull request
Nov 2, 2023
We encountered another segfault similar to the one fixed in #1432. This time, it's related to the pid field in exit events. Fix this by making a copy of the exit event before filtering. Also optimize copying logic to only perform the copy when absolutely necessary. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added a commit
that referenced
this pull request
Nov 2, 2023
[upstream commit 6b34552] We encountered another segfault similar to the one fixed in #1432. This time, it's related to the pid field in exit events. Fix this by making a copy of the exit event before filtering. Also optimize copying logic to only perform the copy when absolutely necessary. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added a commit
that referenced
this pull request
Nov 2, 2023
[upstream commit 6b34552] We encountered another segfault similar to the one fixed in #1432. This time, it's related to the pid field in exit events. Fix this by making a copy of the exit event before filtering. Also optimize copying logic to only perform the copy when absolutely necessary. Signed-off-by: William Findlay <will@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we keep them in the process cache, removing fields may affect the correctness of the process cache. In order to fix that, we create a copy of the event and apply fieldFilters only on the copy.
FIXES: #1428