Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: Generate PodInfo client #1479

Merged
merged 1 commit into from Sep 15, 2023
Merged

k8s: Generate PodInfo client #1479

merged 1 commit into from Sep 15, 2023

Conversation

michi-covalent
Copy link
Contributor

I forgot to add "// +genclient" for PodInfo.

@michi-covalent
k8s: Generate PodInfo client
e094b85 
I forgot to add "// +genclient" for PodInfo.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested a review from a team as a code owner September 15, 2023 21:42
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Sep 15, 2023
mtardy
mtardy approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know this genclient but I'm sure it's crazy good

@michi-covalent michi-covalent merged commit 489c896 into main Sep 15, 2023
26 of 27 checks passed
@michi-covalent michi-covalent deleted the pr/michi/podinfo-client branch September 15, 2023 23:09
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michi-covalent @mtardy