Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc_reader: avoid warning for pid=0 #1554

Merged
merged 1 commit into from Oct 5, 2023
Merged

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Oct 5, 2023

In some cases, we try to get the docker of pid=0, which fails and produces the following warning:
time="2023-10-04T10:27:14Z" level=warning msg="Procfs execve event pods/ identifier error" error="open /procRoot/0/cgroup: no such file or directory"

This warning is confusing, so avoid it by not calling the relevant code for pid=0.

@kkourt kkourt requested a review from a team as a code owner October 5, 2023 06:32
@kkourt kkourt requested a review from tpapagian October 5, 2023 06:32
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit a610e13
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/651e778fd6783d0008b8696f
😎 Deploy Preview https://deploy-preview-1554--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

In some cases, we try to get the docker of pid=0, which fails and
produces the following warning:
time="2023-10-04T10:27:14Z" level=warning msg="Procfs execve event pods/ identifier error" error="open /procRoot/0/cgroup: no such file or directory"

This warning is confusing, so avoid it by not calling the relevant code
for pid=0.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Oct 5, 2023
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if inside procsDockerId() check and return "" and nil is better.

Thanks!

@kkourt kkourt merged commit dd578ef into main Oct 5, 2023
31 of 33 checks passed
@kkourt kkourt deleted the pr/kkourt/avoid-pid0-warn branch October 5, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants