Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Add support to pass options through spec #1626

Merged
merged 6 commits into from Oct 30, 2023

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Oct 20, 2023

Adding support to process options passed in spec for kprobe sensor.

At the moment the only supported option is to disable kprobe multi
(like with --disable-kprobe-multi option).

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Oct 20, 2023
@olsajiri olsajiri force-pushed the pr/olsajiri/options_spec branch 3 times, most recently from 775b501 to 33a8706 Compare October 24, 2023 18:01
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit c9a7614
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/653f594d3251aa0008ff2a6c
😎 Deploy Preview https://deploy-preview-1626--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri force-pushed the pr/olsajiri/options_spec branch 5 times, most recently from 11f7240 to 1153968 Compare October 25, 2023 07:43
@olsajiri olsajiri marked this pull request as ready for review October 25, 2023 08:39
@olsajiri olsajiri requested review from mtardy and a team as code owners October 25, 2023 08:39
@olsajiri olsajiri requested a review from kkourt October 25, 2023 18:22
Copy link
Member

@tpapagian tpapagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some small comments but nothing critical.

pkg/sensors/tracing/options.go Outdated Show resolved Hide resolved
Removing GenericTracepointConf type as a cleanup, because that
abstraction is not actually needed anywhere.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding possibility to specify option for the set.

It's an array of name/value pairs and it's meant to be
processed and interpreted by each sensor.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
We are about to pass options to createGenericKprobeSensor function,
so it's better the function takes the whole spec poitner rather
than adding another function argument.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding support to process options passed in spec for kprobe sensor.

At the moment the only supported option is to disable kprobe multi
(like with --disable-kprobe-multi option).

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
We can now localy disable kprobe multi, let's use it for
security_ override test, which won't work with kprobe multi.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@kkourt kkourt merged commit 3fe3708 into main Oct 30, 2023
36 checks passed
@kkourt kkourt deleted the pr/olsajiri/options_spec branch October 30, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants