Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update tetragon logos in docs where necessary #1658

Merged
merged 1 commit into from Oct 27, 2023
Merged

docs: update tetragon logos in docs where necessary #1658

merged 1 commit into from Oct 27, 2023

Conversation

hacktivist123
Copy link
Member

Fixes: #1623

@hacktivist123 hacktivist123 requested review from mtardy and a team as code owners October 26, 2023 10:10
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit c0e364f
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/653b7e99b4ffa1000848352f
😎 Deploy Preview https://deploy-preview-1658--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tpapagian tpapagian added the release-note/docs This PR updates the documentation. label Oct 26, 2023
@mtardy mtardy self-assigned this Oct 26, 2023
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this 🙏 , I have some comments though:

image

It would be great to replace all the favicons without the "Tetragon" text. Just the logo.

The aliasing sometimes looks completely off on the main logo in the top left corner, I'm not sure we use a SVG here but that could explain, maybe it's better to have a bitmap file like a png for this use case. It's not really problematic we can still fix this later.
Pasted Graphic

Then nits: this one is not centered, and we would need to redo the main image or make it less big but that's maybe out of scope:

image image

@hacktivist123
Copy link
Member Author

Thanks a lot for doing this 🙏 , I have some comments though:

image

It would be great to replace all the favicons without the "Tetragon" text. Just the logo.

The aliasing sometimes looks completely off on the main logo in the top left corner, I'm not sure we use a SVG here but that could explain, maybe it's better to have a bitmap file like a png for this use case. It's not really problematic we can still fix this later.

Pasted Graphic

Then nits: this one is not centered, and we would need to redo the main image or make it less big but that's maybe out of scope:

image image

Got it! I'll replace the favicons with the logo containing just the shield. For the logo on top, I'll switch it to a png and see if it changes.

The hero logo needs to be reworked to fit the landing page and also the one on the getting started docs page too. I tried to adjust it with css but it just wouldn't centralize.

@mtardy
Copy link
Member

mtardy commented Oct 27, 2023

Got it! I'll replace the favicons with the logo containing just the shield. For the logo on top, I'll switch it to a png and see if it changes.

Thanks that's nice!

The hero logo needs to be reworked to fit the landing page and also the one on the getting started docs page too. I tried to adjust it with css but it just wouldn't centralize.

yeah don't spend time and worry about that we'll do that later :)

Fixes: #1623

Signed-off-by: Shedrack Akintayo <akintayoshedrack@gmail.com>
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, we have fixes to do esthetical fixes to do but the bee is gone 🥲! Thanks!

@mtardy mtardy merged commit 6c0b8e5 into cilium:main Oct 27, 2023
4 checks passed
@hacktivist123 hacktivist123 deleted the new-logo branch October 31, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Tetragon logo
3 participants