New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update tetragon logos in docs where necessary #1658
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this 🙏 , I have some comments though:
It would be great to replace all the favicons without the "Tetragon" text. Just the logo.
The aliasing sometimes looks completely off on the main logo in the top left corner, I'm not sure we use a SVG here but that could explain, maybe it's better to have a bitmap file like a png for this use case. It's not really problematic we can still fix this later.
Then nits: this one is not centered, and we would need to redo the main image or make it less big but that's maybe out of scope:
Thanks that's nice!
yeah don't spend time and worry about that we'll do that later :) |
Fixes: #1623 Signed-off-by: Shedrack Akintayo <akintayoshedrack@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, we have fixes to do esthetical fixes to do but the bee is gone 🥲! Thanks!
Fixes: #1623