helm: Add extensions templates #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/helm
lambdanis
force-pushed
the
pr/lambdanis/helm-extensions
branch
from
8388d44
to
158ac2e
Compare
The goal is to make it easy to build custom distributions of Tetragon Helm chart. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/helm-extensions
branch
from
158ac2e
to
221bdad
Compare
chancez
reviewed
Dec 13, 2023
| @@ -51,6 +51,7 @@ | |||
| mountPath: {{ .mountPath }} | |||
| readOnly: {{ .readOnly }} | |||
| {{- end }} | |||
| {{- include "tetragon.volumemounts.extra" . | nindent 4 }} | |||
There was a problem hiding this comment.
Does it make sense to pass the output of include to toYaml before indenting? eg:
{{- include "tetragon.volumemounts.extra" . | toYaml | nindent 4 }}
There was a problem hiding this comment.
I would expect these extensions to be yaml already, but I guess it won't hurt
There was a problem hiding this comment.
No, toYaml converts templates to string literals actually. I think it's less error-prone to define yaml correctly in the extension and avoid complicating it here.
kkourt
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make it easy to build custom distributions of Tetragon Helm chart.