exporter: return err when exporter fails to start #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, when Tetragon encounters an error in its initial configuration, we expect the agent to fail to start and return an appriate error explaining the configuration issue. This is the case for many aspects of initialization, except for the exporter which currently just logs an error message. This is perplexing behaviour because users who want to configure an exporter generally consume Tetragon events that way, so it makes no sense to simply refuse to export events and merrily hum along. Fix this issue by returning an appropriate error when the exporter fails to start so we can bubble it up. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added
the
release-note/minor
willfindlay
deleted the
pr/willfindlay/error-on-exporter-not-starting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, when Tetragon encounters an error in its initial configuration, we expect the agent to fail to start and return an appriate error explaining the configuration issue. This is the case for many aspects of initialization, except for the exporter which currently just logs an error message. This is perplexing behaviour because users who want to configure an exporter generally consume Tetragon events that way, so it makes no sense to simply refuse to export events and merrily hum along. Fix this issue by returning an appropriate error when the exporter fails to start so we can bubble it up.