Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix contribution-guide docker run #2310

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

yukinakanaka
Copy link
Contributor

@yukinakanaka yukinakanaka commented Apr 8, 2024

Fixes: #2293

Current docker run doesn't work. ENTRYPOINT is set as /usr/bin/tetragon in Dockerfile, so arguments for docker run are not needed.

Tetragon's container was created successfully via the new command:

$ docker run --name tetragon \
   --rm -it -d --pid=host \
   --cgroupns=host --privileged \
   -v /sys/kernel/btf/vmlinux:/var/lib/tetragon/btf \
   cilium/tetragon:latest
27016a8ee505aed876f9d7426e60d4ca347689ae56acd1f321192deae2b142f9

$ docker ps
CONTAINER ID   IMAGE                    COMMAND                  CREATED         STATUS          PORTS                       NAMES
27016a8ee505   cilium/tetragon:latest   "/usr/bin/tetragon"      3 seconds ago   Up 2 seconds                                tetragon

Signed-off-by: yukinakanaka <yuki.nakamura@mapbox.com>
@yukinakanaka yukinakanaka requested review from mtardy and a team as code owners April 8, 2024 06:44
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit c39cc4d
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66139251503e340008ec3f00
😎 Deploy Preview https://deploy-preview-2310--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Apr 8, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot this is correct, I changed the entrypoint and didn't update this part of the doc, thanks again! :)

@mtardy mtardy merged commit d951385 into cilium:main Apr 8, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: contribution-guide's docker run is broken
2 participants