tests/e2e: improvements to testing workflow #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willfindlay
commented
Sep 6, 2022
willfindlay
commented
- Add a -tetragon.btf flag to tests/e2e for easily using a custom BTF file in a KinD cluster
- Add some extra flags to the Makefile for more easily configuring test options, including a BTF file to use
This commit adds a convenience flag for easily passing a BTF file to the end-to-end tests to be used instead of system BTF. Works only for KinD tests. Signed-off-by: William Findlay <will@isovalent.com>
This commit adds the following new flags to the Makefile for running e2e tests. They
should be particularly helpful in environments where system BTF is not available, e.g.
4.19 kernels.
- E2E_AGENT: agent image to use for tests, defaults to "cilium/tetragon:$(DOCKER_IMAGE_TAG)"
- E2E_OPERATOR: operator image to use for tests, defaults to "cilium/tetragon-operator:$(DOCKER_IMAGE_TAG)"
- E2E_BTF: if non-empty, btf file to use instead of system BTF, defaults to empty
- E2E_BUILD_IMAGES: if non-zero, build local images before running tests, default is 1
With these changes, running e2e tests on 4.19 should be as simple as:
make e2e-test E2E_BTF=/path/to/btf
And running tests with CI images should be as simple as, for example:
make e2e-test E2E_AGENT=quay.io/cilium/tetragon-ci:1e568613d853bbb83587d8f7f80a2aa56c8eaf59 E2E_OPERATOR=quay.io/cilium/tetragon-operator-ci:1e568613d853bbb83587d8f7f80a2aa56c8eaf59 E2E_BUILD_IMAGES=0
Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
force-pushed
the
pr/willfindlay/btf
branch
from
354710c
to
01c5e5d
Compare
Avoid duplicating the e2e test command in CI and use make instead now that we have a fancy new target. Signed-off-by: William Findlay <will@isovalent.com>
kevsecurity
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.