tetragon: Add clang 14 #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we can't use the workaround for clang 14 introduced in 754cdbe , because it unrolls into ~16k instructions and it breaks validation for us later in other code that uses this function |
olsajiri
force-pushed
the
clang_14
branch
5 times, most recently
from
93d0692
to
77f05e5
Compare
olsajiri
force-pushed
the
clang_14
branch
3 times, most recently
from
e67c64b
to
7d85d9e
Compare
|
@willfindlay I guess you could unblock the CI? thnx |
Switching to clang-14 in Dockerfile.clang, the new version is 14.0.0-1ubuntu1. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
The clang 14 seems to use dwarf 5 by default and TestStructAlignments can't read it properly and fails. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Clang tries to unroll the prepend_path which ends up in really big code which does not pass verifier. Making sure it's always unrolled for __LARGE_BPF_PROG programs. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Switching to clang 14. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
|
using #397 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use clang 14
Signed-off-by: Jiri Olsa jolsa@kernel.org