-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Add pprof http support #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thank you for the contribution!
Could you please add a "Signed-off-by:" according to https://docs.cilium.io/en/v1.12/contributing/development/contributing_guide/#dev-coo? I'd also suggest rebasing to master so that this CI #557 fix is included.
Thanks again!
@kkourt Rebased and added |
Could you also please add it in the git commit as well? |
Check patch still complains. Also it would have been great if you added ina separate patch some docs under Thank you, LGTM! |
This PR adds support for pprof http endpoints. Fixes: cilium#550 Signed-off-by: Andzej Maciusovic <andzej.maciusovic@gmail.com>
@kkourt Ah, sorry about that. Added signoff to git commit. |
Great! Many thanks! |
This PR adds support for pprof http endpoints.
Fixes: #550
Signed-off-by: Andzej Maciusovic andzej.maciusovic@gmail.com