Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tetragon: Add pprof http support #551

Merged
merged 1 commit into from
Nov 29, 2022
Merged

tetragon: Add pprof http support #551

merged 1 commit into from
Nov 29, 2022

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Nov 21, 2022 •
edited
Loading

This PR adds support for pprof http endpoints.

Fixes: #550

Signed-off-by: Andzej Maciusovic andzej.maciusovic@gmail.com

@anjmao anjmao requested a review from a team as a code owner November 21, 2022 17:06
@anjmao anjmao requested a review from tixxdz November 21, 2022 17:06
kkourt
kkourt approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

cmd/tetragon/main.go Outdated Show resolved Hide resolved
kkourt
kkourt requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thank you for the contribution!

Could you please add a "Signed-off-by:" according to https://docs.cilium.io/en/v1.12/contributing/development/contributing_guide/#dev-coo? I'd also suggest rebasing to master so that this CI #557 fix is included.

Thanks again!

@anjmao anjmao requested review from kkourt and removed request for tixxdz November 28, 2022 08:58
@anjmao
Copy link
Contributor Author

anjmao commented Nov 28, 2022

@kkourt Rebased and added Signed-off-by text.

@kkourt
Copy link
Contributor

kkourt commented Nov 28, 2022

@kkourt Rebased and added Signed-off-by text.

Could you also please add it in the git commit as well? git commit --amend --signoff should do the trick.
Thanks!

@tixxdz
Copy link
Member

tixxdz commented Nov 28, 2022

Check patch still complains. Also it would have been great if you added ina separate patch some docs under docs/debugging/README.md a section for profiling Tetragon agent with examples and output, so we can run them.

Thank you, LGTM!

@anjmao
tetragon: Add pprof http support
d77be31 
This PR adds support for pprof http endpoints.

Fixes: cilium#550

Signed-off-by: Andzej Maciusovic <andzej.maciusovic@gmail.com>
@anjmao
Copy link
Contributor Author

anjmao commented Nov 29, 2022

@kkourt Ah, sorry about that. Added signoff to git commit.

@kkourt kkourt merged commit 53a8f08 into cilium:main Nov 29, 2022
@kkourt
Copy link
Contributor

kkourt commented Nov 29, 2022

@kkourt Ah, sorry about that. Added signoff to git commit.

Great! Many thanks!

@mtardy mtardy mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose pprof http endpoints
3 participants
@anjmao @kkourt @tixxdz