Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventcache: update PodInfoError on pod error #609

Merged
merged 1 commit into from
Jan 5, 2023
Merged

eventcache: update PodInfoError on pod error #609

merged 1 commit into from
Jan 5, 2023

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jan 5, 2023

There seems to be a typo where we update the ProcessInfoError metric even when the error ErrFailedToGetPodInfo.

Signed-off-by: Kornilios Kourtis kornilios@isovalent.com

@kkourt
eventcache: update PodInfoError on pod error
e1a2fca 
There seems to be a typo where we update the ProcessInfoError metric
even when the error ErrFailedToGetPodInfo.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt requested a review from a team as a code owner January 5, 2023 13:46
@kkourt kkourt requested a review from olsajiri January 5, 2023 13:46
@kkourt kkourt added the needs-backport/0.8 This PR needs backporting to 0.8 label Jan 5, 2023
tpapagian
tpapagian approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@tpapagian tpapagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kkourt kkourt merged commit 8fd660d into main Jan 5, 2023
@kkourt kkourt deleted the pr/kkourt/podinfo-error branch January 5, 2023 14:34
@tixxdz tixxdz mentioned this pull request Jan 25, 2023
Merged
@tixxdz tixxdz added backport-pending/0.8 The backport for this PR is in progress backport-done/0.8 PR backport to 0.8 complete. and removed needs-backport/0.8 This PR needs backporting to 0.8 backport-pending/0.8 The backport for this PR is in progress labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpapagian tpapagian tpapagian approved these changes

@olsajiri olsajiri Awaiting requested review from olsajiri olsajiri is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
backport-done/0.8 PR backport to 0.8 complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kkourt @tpapagian @tixxdz